Drop support for legacy Python#174
Merged
StoicLoofah merged 2 commits intoggtracker:upstreamfrom Jun 12, 2022
Merged
Conversation
StoicLoofah
approved these changes
Jun 12, 2022
Collaborator
StoicLoofah
left a comment
StoicLoofah
left a comment
There was a problem hiding this comment.
Glanced through this, but to be honest, I trust the tests more than my eye. Also always good to have automated solutions
Thanks for the work here!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove support for all end-of-life versions of Python so that we now support current versions of Python.
This was done by running
pyupgrade --py37-plus **/*.pywhich removes 168 lines of unnecessary code.Python f-strings are easier to read and are faster: https://www.scivision.dev/python-f-string-speed
The CircleCI Python2 job was removed so a maintainer should remove Python2 as a required job below.